Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce difference between local and CI environments #1518

Merged
merged 3 commits into from
Jun 25, 2022
Merged

Reduce difference between local and CI environments #1518

merged 3 commits into from
Jun 25, 2022

Conversation

wren
Copy link
Member

@wren wren commented Jun 25, 2022

This makes development more consistent, since the exact same commands are being run locally as in the pipelines.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

wren added 3 commits June 25, 2022 12:31
@wren
Clean up pyproject file
47c868d 
This reduces the differences between local tasks and tasks run in the CI
pipelines
@wren
remove linting step (it's part of test now)
c84e779
@wren
remove useless arg
070cdd9
@micahellison micahellison added the build Issues related to the build pipeline label Jun 25, 2022
@micahellison micahellison merged commit 23bc0f2 into jrnl-org:develop Jun 25, 2022
@micahellison micahellison deleted the clean-pyproject branch June 25, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
build Issues related to the build pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wren @micahellison