Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simplify plugin to linting checks #1630

Merged
merged 8 commits into from
Nov 5, 2022

Conversation

wren
Copy link
Member

@wren wren commented Oct 30, 2022

We recently added flakeheaven to our linting checks. This PR adds a flake8-simplify to look for more general issues with code complexity, and provide specific advice on how to fix those issues. Running this locally, we had a few issues already in the codebase, so this PR also fixes those issues so the new checks can start from a neutral state.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

wren added 3 commits November 1, 2022 21:03
Conflicts:
  poetry.lock
  pyproject.toml
Conflicts:
  poetry.lock
  pyproject.toml
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@micahellison micahellison added test Issues related to tests we need to add build Issues related to the build pipeline labels Nov 5, 2022
@micahellison micahellison merged commit b508ed6 into jrnl-org:develop Nov 5, 2022
@micahellison micahellison deleted the flake-simplify branch November 5, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline test Issues related to tests we need to add
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants