Add more type hints #1642
Merged
Add more type hints #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wren
reviewed
Jan 7, 2023
| @@ -96,7 +96,7 @@ def _encrypt(self, text: str) -> bytes: | |||
|
|
|||
| return self.encryption_method.encrypt(text) | |||
|
|
|||
| def open(self, filename=None): | |||
| def open(self, filename: str | None = None) -> "Journal": | |||
There was a problem hiding this comment.
Can we use Optional[str] instead of str | None?
There was a problem hiding this comment.
They are equivalent right? So we could, but I have typed this consistently as str | None in #1614
Anything wrong with the new syntax?
micahellison
reviewed
Jan 7, 2023
| @@ -17,7 +18,7 @@ def __str__(self) -> str: | |||
| JRNLV2 = "Jrnlv2Encryption" | |||
|
|
|||
|
|
|||
| def determine_encryption_method(config: str | bool) -> "BaseEncryption": | |||
| def determine_encryption_method(config: str | bool) -> Type["BaseEncryption"]: | |||
wren
requested changes
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some more type hints now that #1602 is merged.
cc: #1608
Checklist
for the same issue.