-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only read text files that look like entries when opening folder journal #1697
Merged
wren
merged 15 commits into
jrnl-org:develop
from
micahellison:folder-journal-file-read-1692
Apr 29, 2023
Merged
Only read text files that look like entries when opening folder journal #1697
wren
merged 15 commits into
jrnl-org:develop
from
micahellison:folder-journal-file-read-1692
Apr 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Talking with @wren about this and I now want to re-do this whole PR:
|
- move get_files into FolderJournal class and add underscore prefix - create iterables to get for year/month folders and day files - make year/month/day file reading strict: only exact expected months and days out of all possible months and days
micahellison
changed the title
Only read text files that look like entries when opening folder journal
[WIP] Only read text files that look like entries when opening folder journal
Mar 25, 2023
wren
changed the title
[WIP] Only read text files that look like entries when opening folder journal
Only read text files that look like entries when opening folder journal
Apr 29, 2023
wren
approved these changes
Apr 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕥
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1692.
Checklist
for the same issue.
I didn't add a new test for this specifically, but rather, I modified the test folder journal to include entries that should be ignored. Without the change in
FolderJournal.py
, the tests blow up quite fantastically.