Confirm that each journal can be parsed during upgrade, and abort upgrade if not #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd aborting upgrade if not
wren
requested changes
Aug 24, 2019
jrnl/upgrade.py
Outdated
| ) | ||
|
|
||
| util.prompt("Aborting upgrade.") | ||
| return |
There was a problem hiding this comment.
We should use an exception here instead of returning. Once this function returns, a bunch of other code will still run (like upgrading the config), and not fully abort the upgrade.
There was a problem hiding this comment.
Agreed - just made the change.
Handling it in install.py to prevent config from being overwritten when upgrade fails
wren
reviewed
Aug 24, 2019
| util.prompt("Aborting upgrade. Exiting.") | ||
| util.prompt("Aborting upgrade.") | ||
| util.prompt("Please tell us about this problem at the following URL:") | ||
| util.prompt("https://github.com/jrnl-org/jrnl/issues/new?title=UpgradeValidationException") |
micahellison
changed the title
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And aborting upgrade if not.
This change also moves upgrade-related tests into their own upgrade.feature file.