Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.6+ #710

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Support Python 3.6+ #710

merged 1 commit into from
Nov 12, 2019

Conversation

pspeter
Copy link
Contributor

@pspeter pspeter commented Nov 4, 2019

As discussed in #615, we can and should support Python from version 3.6 and up. This PR:

  • adds all supported Python versions to Travis,
  • tells poetry and therefore pypi that 3.6+ is supported.

@pspeter
Copy link
Contributor Author

pspeter commented Nov 4, 2019 •
edited
Loading

Looks like the custom template export fails in 3.8. I'm not familiar with this part of the code, but it seems to throw an Error somewhere during parsing:

NotImplementedError
"-" * len(entry.title)
'Constant' not supported

I'm not sure what to think of the custom template feature in general. It seems stamped together with regex and complicated parsing logic. Do we want to maintain this? I don't even have a clue where the error might be coming from.

Update:
It looks like the poetry install in the travis before_install is clashing with some of our dependencies. Not sure if that's related to the issue but its probably not ideal.

@pspeter pspeter mentioned this pull request Nov 5, 2019
Closed
@wren wren added this to the v2.1.2 - Non-critical bug fixes milestone Nov 9, 2019
@wren
Copy link
Member

wren commented Nov 9, 2019

Since it's causing so much trouble, can you drop 3.8 from this PR and file a separate issue for it? That'll let us get 3.6 support in, and deal with the template issues with a bit more time.

@wren wren changed the base branch from master to v2.1.2 November 9, 2019 22:51
@wren wren changed the base branch from v2.1.2 to master November 9, 2019 22:51
@pspeter pspeter force-pushed the support-py3-6 branch 2 times, most recently from be7de16 to fba700b Compare November 12, 2019 17:13
@pspeter
Clarify currently supported Python versions
b5c05cd 
The Python 3.8 build currently fails on travis, this should be dealt with in a future PR along with updating the travis config and pyproject.toml
@pspeter pspeter mentioned this pull request Nov 12, 2019
Closed
@pspeter
Copy link
Contributor Author

pspeter commented Nov 12, 2019

can you drop 3.8 from this PR and file a separate issue for it?

Done!

wren
wren approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wren wren merged commit 4318da5 into jrnl-org:master Nov 12, 2019
@wren wren added the enhancement New feature or request label Jan 10, 2020
@pspeter pspeter deleted the support-py3-6 branch February 22, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wren wren wren approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@pspeter @wren @micahellison