Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display header in docs on mobile devices #763

Merged
merged 1 commit into from
Nov 30, 2019

Conversation

maebert
Copy link
Contributor

@maebert maebert commented Nov 29, 2019

Fixes #760.

Headers were not visible because of a transparent background. This commit will give the header the same gradient treatment as the sidebar, which will expose the hamburger menu - tapping the menu shows the sidebar for navigation.

image

image

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?

@maebert maebert added the documentation Improvements or additions to documentation label Nov 29, 2019
@maebert maebert requested a review from wren November 29, 2019 20:54
@wren wren changed the base branch from master to develop November 30, 2019 18:43
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wren wren merged commit 7e373bb into jrnl-org:develop Nov 30, 2019
@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation 🔒 Outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs site has no mobile menu
2 participants