Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lock file and testing suite for Python 3.8 #765

Merged
merged 2 commits into from
Nov 30, 2019
Merged

Update lock file and testing suite for Python 3.8 #765

merged 2 commits into from
Nov 30, 2019

Conversation

wren
Copy link
Member

@wren wren commented Nov 30, 2019 •
edited
Loading

Closes #739
Adds to #747

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?

@wren wren added this to the v2.1.2 - Non-critical bug fixes milestone Nov 30, 2019
micahellison
micahellison approved these changes Nov 30, 2019
View reviewed changes
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒🔓

@micahellison micahellison merged commit 34b07d3 into jrnl-org:develop Nov 30, 2019
@wren wren deleted the python-38-739 branch November 30, 2019 21:55
@wren wren added the build Issues related to the build pipeline label Jan 10, 2020
@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
build Issues related to the build pipeline 🔒 Outdated
Projects
None yet
Milestone
v2.1.2
Development

Successfully merging this pull request may close these issues.

Add Python 3.8 support
2 participants
@wren @micahellison