Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update YAML exporter to handle Dayone format #773

Merged
merged 6 commits into from
Jan 26, 2020
Merged

Update YAML exporter to handle Dayone format #773

merged 6 commits into from
Jan 26, 2020
+32 −12

Conversation

MinchinWeb
Copy link
Contributor

This is split out of #159 et al to just contain those parts that extend the YAML exporter to also export DayOne metadata.

The code has been "black formatted".

Currently, jrnl may be stripping this metadata, so another PR (also split from #159) will be added to fix that.

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass -- ish. I have 6 failing tests, but I think it's Windows issues rather than anything I changed here.
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable? -- I don't think any apply really...

@MinchinWeb
Copy link
Contributor Author

@wren : the issue to support this is #159 -- this comment in particular

@wren wren changed the base branch from develop to master January 4, 2020 20:43
@wren wren changed the base branch from master to develop January 4, 2020 20:43
wren
wren reviewed Jan 4, 2020
View reviewed changes
jrnl/plugins/yaml_exporter.py Outdated Show resolved Hide resolved
@MinchinWeb
Copy link
Contributor Author

@wren I think this one is ready to go!

wren
wren approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MinchinWeb
Copy link
Contributor Author

@wren Can this be merged in? It looks like everything is good, and you've signed off on it. Not sure what's next...

@wren
Copy link
Member

wren commented Jan 23, 2020

Yup, this will likely go into the next version. Just focusing on the v2.2 beta version right now.

@wren wren merged commit e54da41 into jrnl-org:develop Jan 26, 2020
@wren wren changed the title [DayOne] YAML export improvements Update YAML exporter to handle Dayone format Jan 26, 2020
@wren wren added the enhancement New feature or request label Jan 26, 2020
@micahellison micahellison mentioned this pull request Feb 8, 2020
Closed
wren pushed a commit that referenced this pull request Apr 18, 2020
@MinchinWeb
[DayOne] YAML export improvements (#773)
2b605f8 
* [YAML Export] code style improvements

* [Dayone] Brings back extended Dayone attributes to YAML export
c.f. 7d3afd8
reverse b8dbf84

* [YAML Exporter] switch to f-strings

* [Black] apply black formatter to YAML Exporter

* Code fixes as per review
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
@MinchinWeb MinchinWeb deleted the dayone-yaml-export branch May 21, 2020 02:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wren wren wren approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request 🔒 Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MinchinWeb @wren