Fix all skipped tests on Travis Windows builds by preserving newlines #823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been having trouble with Windows tests on Travis for a while, but I noticed some of them were passing on my local Windows machine today. Turns out I had the dreaded autocrlf setting set to false on my machine, whereas it defaults to true on Travis.
This PR tells Travis to keep the setting false, which prevents it from changing newlines when it checks out files. It also removes all the
skip_win
directives that were used to skip tests that were failing on Windows due to this issue.Checklist