Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all skipped tests on Travis Windows builds by preserving newlines #823

Merged
merged 3 commits into from
Jan 26, 2020
Merged

Fix all skipped tests on Travis Windows builds by preserving newlines #823

merged 3 commits into from
Jan 26, 2020

Conversation

micahellison
Copy link
Member

We've been having trouble with Windows tests on Travis for a while, but I noticed some of them were passing on my local Windows machine today. Turns out I had the dreaded autocrlf setting set to false on my machine, whereas it defaults to true on Travis.

This PR tells Travis to keep the setting false, which prevents it from changing newlines when it checks out files. It also removes all the skip_win directives that were used to skip tests that were failing on Windows due to this issue.

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • [n/a] Have you written new tests for your core changes, as applicable?

@micahellison micahellison added the build Issues related to the build pipeline label Jan 25, 2020
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just so beautiful. 😭

Thank you!

@wren wren merged commit 0c9b283 into jrnl-org:develop Jan 26, 2020
@micahellison micahellison deleted the travis-windows-tests branch January 26, 2020 17:52
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Issues related to the build pipeline 🔒 Outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants