Updating/clarifying template explanation #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahellison
requested changes
Feb 1, 2020
|
Thank you for your questions and pointing out the errors. I realized that I could edit the doc and make the changes you were commenting on. After you comment, should I respond to each/resolve the comment/make the changes, respond to each/leave comments open/don't make changes, or respond to complex comments/close out smaller changes after their made? |
heymajor
commented
Feb 2, 2020
micahellison
previously approved these changes
Feb 5, 2020
|
This looks great! Thank you for your work on this. |
micahellison
approved these changes
Feb 5, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only affects documentation. Updating/clarifying templates and use cases. A broken link was removed, and the info was re-purposed.
I appreciate this code being available.
Super nervous about this/hope I didn't cross any lines and followed the requested process - my first pull request ;)