Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure exported entries end in a newline for Markdown and YAML exporters #908

Merged
merged 6 commits into from
Apr 11, 2020

Conversation

MinchinWeb
Copy link
Contributor

@MinchinWeb MinchinWeb commented Apr 7, 2020

Fixes #768, Fixes #881.

If the exported entry does not have a final empty line, this will add one on export. Some Markdown parsers get picky about not having a empty line above a heading....

The newline added is os.linesep, so cross platform issues shouldn't arise.

Also includes tests.

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable? Yup!

…newline

Fixes jrnl-org#768, Fixes jrnl-org#881.

If the exported entry does not have a final empty line, this will add one on export. Some Markdown parsers get picky about not having a empty line above a heading....
to deal with inconsistent default file ordering on different OS's
@MinchinWeb MinchinWeb force-pushed the markdown-newline-end branch from 0ad76eb to 2a9d6b2 Compare April 7, 2020 16:06
@wren wren changed the title [Markdown Exporter] [YAML Exporter] Ensure exported entires end in a newline Ensure exported entries end in a newline for Markdown and YAML exporters Apr 11, 2020
@wren wren added the bug Something isn't working label Apr 11, 2020
@wren
Copy link
Member

wren commented Apr 11, 2020

Ugh, Travis is having some issues again. This looks good, so I'll merge when I can run the tests again.

@wren wren merged commit 3027d5c into jrnl-org:develop Apr 11, 2020
@MinchinWeb MinchinWeb deleted the markdown-newline-end branch April 12, 2020 02:32
wren added a commit that referenced this pull request Apr 18, 2020
…ers (#908)

* [Markdown Exporter] [YAML Exporter] Ensure exported entires end in a newline

Fixes #768, Fixes #881.

If the exported entry does not have a final empty line, this will add one on export. Some Markdown parsers get picky about not having a empty line above a heading....

* fix black formatting issues
* explicitly sort filenames

to deal with inconsistent default file ordering on different OS's
* Update .gitignore
* Update test for typo fix

Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
wren added a commit that referenced this pull request Apr 18, 2020
…ers (#908)

* [Markdown Exporter] [YAML Exporter] Ensure exported entires end in a newline

Fixes #768, Fixes #881.

If the exported entry does not have a final empty line, this will add one on export. Some Markdown parsers get picky about not having a empty line above a heading....

* fix black formatting issues
* explicitly sort filenames

to deal with inconsistent default file ordering on different OS's
* Update .gitignore
* Update test for typo fix

Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
wren added a commit that referenced this pull request Jul 25, 2020
…ers (#908)

* [Markdown Exporter] [YAML Exporter] Ensure exported entires end in a newline

Fixes #768, Fixes #881.

If the exported entry does not have a final empty line, this will add one on export. Some Markdown parsers get picky about not having a empty line above a heading....

* fix black formatting issues
* explicitly sort filenames

to deal with inconsistent default file ordering on different OS's
* Update .gitignore
* Update test for typo fix

Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown export adds only one \n before second ### Markdown export bug
2 participants