Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python 3.9 incompatibility by updating plistlib #909

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Fix Python 3.9 incompatibility by updating plistlib #909

merged 1 commit into from
Apr 11, 2020

Conversation

MinchinWeb
Copy link
Contributor

@MinchinWeb MinchinWeb commented Apr 7, 2020 •
edited by wren
Loading

Fixes #793

The API of the standard library's plistlib changed with version 3.4 of Python, and the old API is being removed in Python 3.9. In other words, the new API is supported by all version of Python we current support (3.6 to 3.8).

This should (hopefully) allow our Python 3.9 tests to pass.

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ n/a ] Have you written new tests for your core changes, as applicable?

@MinchinWeb MinchinWeb force-pushed the plistlib branch 2 times, most recently from 0584a9a to 9a2662c Compare April 7, 2020 16:37
@MinchinWeb
[DayOne] support moderm plistlib
4678432 
The API of the standard library's `plistlib` changed with version 3.4 of Python, and the old API is being removed in Python 3.9. In other words, the new API is supported by all version of Python we current support (3.6 to 3.8).

See https://docs.python.org/3.4/library/plistlib.html for more details.

This should (hopefully) allow our Python 3.9 tests to pass.
@wren wren added the bug Something isn't working label Apr 11, 2020
@wren wren changed the title [DayOne] support moderm plistlib Fix Python 3.9 incompatibility by updating plistlib Apr 11, 2020
wren
wren approved these changes Apr 11, 2020
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this one on!

@wren wren merged commit ee9974a into jrnl-org:develop Apr 11, 2020
@MinchinWeb MinchinWeb deleted the plistlib branch April 11, 2020 19:15
@wren wren mentioned this pull request Apr 11, 2020
Closed
wren pushed a commit that referenced this pull request Apr 18, 2020
@MinchinWeb
[DayOne] support moderm plistlib (#909)
2bc545a 
The API of the standard library's `plistlib` changed with version 3.4 of Python, and the old API is being removed in Python 3.9. In other words, the new API is supported by all version of Python we current support (3.6 to 3.8).

See https://docs.python.org/3.4/library/plistlib.html for more details.
wren pushed a commit that referenced this pull request Apr 18, 2020
@MinchinWeb
[DayOne] support moderm plistlib (#909)
4fed545 
The API of the standard library's `plistlib` changed with version 3.4 of Python, and the old API is being removed in Python 3.9. In other words, the new API is supported by all version of Python we current support (3.6 to 3.8).

See https://docs.python.org/3.4/library/plistlib.html for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wren wren wren approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.9 build is failing with import error ('Mapping' from 'collections')
2 participants
@MinchinWeb @wren