Fix duplicate text in multiple tag search #948
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #926.
The pretty print feature (#842) highlights all tags by default, but if you search for a particular tag, it only highlights that tag. However, when searching for multiple tags, it would show the entire title and body once for each tag searched for.
This PR removes that selective highlighting (so all tags are highlighted regardless of what you've searched for) and adds a test that catches the duplication bug.
Checklist
poetry run behave
black (consistent code styling). --
poetry run black --check . --verbose --diff
(logically errors and unused imports). --
poetry run pyflakes jrnl features
Pull Requests for the same update/change?
us to include them?