Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate text in multiple tag search #948

Merged
merged 1 commit into from
May 9, 2020

Conversation

micahellison
Copy link
Member

Fixes #926.

The pretty print feature (#842) highlights all tags by default, but if you search for a particular tag, it only highlights that tag. However, when searching for multiple tags, it would show the entire title and body once for each tag searched for.

This PR removes that selective highlighting (so all tags are highlighted regardless of what you've searched for) and adds a test that catches the duplication bug.

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass. --
    poetry run behave
  • The code passes linting via
    black (consistent code styling). --
    poetry run black --check . --verbose --diff
  • The code passes linting via pyflakes
    (logically errors and unused imports). -- poetry run pyflakes jrnl features
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?

Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wren wren merged commit d9b2b2d into jrnl-org:develop May 9, 2020
@wren wren added the bug Something isn't working label May 27, 2020
wren pushed a commit that referenced this pull request Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching for tags prints found entry multiple times
2 participants