Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made it configurable how to handle cr/lf in the input data. #17

Closed
wants to merge 7 commits into from

Conversation

zond
Copy link

@zond zond commented Apr 26, 2014

No description provided.

@jroimartin
Copy link
Owner

Thank you. I will review the PR asap. Currently I am working on other projects, but I plan to come back to the gocui development really soon.

@zond
Copy link
Author

zond commented Apr 29, 2014

Cool :)

I'll just continue using my branch until then.

Great work on gocui by the way - it is completely fantastic compared to
ncurses and friends :D

On Tue, Apr 29, 2014 at 1:10 AM, Roi Martin notifications@git.luolix.topwrote:

Thank you. I will review the PR asap. Currently I am working on other
projects, but I plan to come back to the gocui development really soon.


Reply to this email directly or view it on GitHubhttps://github.com//pull/17#issuecomment-41625509
.

@jroimartin
Copy link
Owner

First of all, sorry for the BIG delay. Could you please check commit 17f7615 to see if it solves this issue? :)

Edit: BTW I made this behaviour "mandatory", so fmt.Print, fmt.Println, etc. work as expected.

@zond
Copy link
Author

zond commented Jan 29, 2015

It looks like it would solve my problem, even if I gave up when I realized that another and much harder problem remained: ANSI control codes :O

I ended up building a distributed app where one terminal runs the input window and several others run output windows that just print everything on stdout and letting the terminal handle all rendering...

@jroimartin
Copy link
Owner

Why would you use ANSI control codes if you control the output? Of course, if you are not generating this output, that would be a problem. Anyway you could filter/replace them, couldn't you?

BTW I'm planning to give color support to gocui in the next days, but probably using some human-friendly syntax (issue #9).

@zond
Copy link
Author

zond commented Jan 29, 2015

Why would you use ANSI control codes if you control the output? Of
course, if you are not generating this output, that would be a problem.

I was building a MUD client, and it was important to render the incoming
data exactly as the server software intended.

Anyway you could filter/replace them, couldn't you?

I built a MUD client like this before, in Ruby, and that time around I used
ncurses and intercepted all incoming ANSI escape codes and replaced them
with ncurses commands.

That was easily the least interesting and most work intensive part of that
client, so I'd rather not do it again ;)

BTW I'm planning to give color support to gocui in the next days, but
probably using some human-friendly syntax (issue #9).

Cool, but consider rendering ANSI commands properly as well, it might come
in handy :)


Reply to this email directly or view it on GitHub.

@jroimartin
Copy link
Owner

I'll take it into account, thanks!

@jroimartin jroimartin closed this Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants