support CJK(chinese, japanese, Korean) #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that giving support for CJK is more complex than that. For example, not only view.go but also [1] edit.go should modified to stop assuming that 1 rune == 1 cell. Could you check wrapping, full edition mode, etc.? Thanks for your contribution :) [1] https://github.com/jroimartin/gocui/blob/master/edit.go |
|
Closed due to inactivity. Anyway, gocui assumes 1 rune / 1 cell in several places, so this change will need more work. I'll evaluate supporting this when I rewrite the internals to support font colors. |
cswank
pushed a commit
to cswank/gocui
that referenced
this pull request
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the old version not support Chinese character.
nsf/termbox-go#71