Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ide hanging when file modified outside of it #164

Merged
merged 3 commits into from
Jul 3, 2015
Merged

Fix ide hanging when file modified outside of it #164

merged 3 commits into from
Jul 3, 2015

Conversation

maldoinc
Copy link
Contributor

This PR fixes issue #112

I could almost-reliably reproduce the issue at hand.

The problem would be that the message box is created as a modal window, then the main form is restored thus causing it (the message box) to stay behind the main form and causing it to freeze or simply not respond.

If you would drag away the form to reveal the message box then answer it the application starts responding normally.

This PR fixes this anomaly.

@martijnlaan
Copy link
Member

Thanks but I can't merge it like this until I fully understand why you changed it like this and why this fixes the problem, especially since this impacts everything and not just the IDE so I can't be sure it doesn't introduce new problems.

Also I wonder why the commit only changes the Unicode version. Does the non Unicode version not have this problem?

@maldoinc
Copy link
Contributor Author

The previous commit did indeed fix the issue but also broke a few things (namely message boxes from forms other than the main one).

To resolve this I reverted that one and added a check via the IsIconic function to detect wether the application is minimized and create a messagebox with a taskbar button.

The problem is mostly reproducible only when the application is minimized via the system minimize button.

@martijnlaan martijnlaan merged commit 836b1db into jrsoftware:master Jul 3, 2015
@martijnlaan
Copy link
Member

Thanks!

jordanrussell added a commit that referenced this pull request Dec 8, 2024
AppMessageBox wasn't compatible with MainFormOnTaskBar=True; it displayed every message box with no owner.

Also found that the VCL doesn't set the owner correctly on dialogs displayed when the app isn't in the foreground. Workaround implemented.

Left the IsIconic call (from #164) in for now, though I don't think it's needed anymore in the IDE as long as message boxes use the main form as their owner. It may still be needed by Setup; haven't yet checked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants