Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Pot connection to rotary #165

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Conversation

balzreber
Copy link
Collaborator

Description

Changed the connection for the two pots to connections for rotary encoders. I had to reroute all Analog Inputs for that to work.

Addresses #164

Type of change

Please delete options that are not relevant.

  • Change ECAD (fixed issue with existing PCB)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

N/A

Checklist: (Delete non-relevant sections)

PCB/ECAD:

  • Schematic completed
  • PCB routed

Changed the connection for the two pots to connections for rotary encoders.
@amanuense
Copy link
Collaborator

taking a look

Copy link
Collaborator

@amanuense amanuense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@jrsteensen jrsteensen merged commit 92c47b8 into master Jan 6, 2020
@jrsteensen jrsteensen deleted the ECAD-DDI_Shield-redesign branch January 6, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants