Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ddi button board pullup resistors #266

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Ddi button board pullup resistors #266

merged 3 commits into from
Nov 2, 2020

Conversation

petersawka
Copy link
Collaborator

@petersawka petersawka commented Nov 1, 2020

Description

Updated Speciality PCB DDI Button Board and AMPCD Button Board with pullup resistors

Addresses # (No existing issue, doesn't really apply to the total redesign, but will help with it.)

Type of change

Please delete options that are not relevant.

  • New MCAD (new Mechanical Model)
  • Change MCAD (fixed issue with existing MCAD model)
  • New ECAD (new PCB)
  • [Y ] Change ECAD (fixed issue with existing PCB)
  • New software module (new software module for slave)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Worked with @dnamaster2000 on existing boards. He soldered on resistors directly to pins to test

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist: (Delete non-relevant sections)

MCAD:

  • Model is in SolidWorks 2019 format
  • Design intent and requirements have been met
  • Design has been fit checked to ensure no interferences exist
  • Design has been integrated into Next Higher Assembly (NHA)

PCB/ECAD:

  • Requirements definition
  • [Y ] Schematic completed
  • [Y ] PCB routed
  • [Y ] PCB constrained by physical footprint limitations
  • [Y] PCB critical component location requirements met
  • [ Y] Schematic/PCB reviewed
  • [N] BOM generated
  • [N] Gerbers generated
  • [N] MCAD generated

Software:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

-Updated Schematic with 10k Pullup Resistors for all Switches
-Updated Schematic, changed to 10K Pullup resistor on SCL, SDA, and INT
-Updated PCB with Pull-up Resistors for Switches
Added Pullup Resistros to AMPCD
Fixed missing connections
Copy link
Owner

@jrsteensen jrsteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved and merging. Thanks for the contribution!

@jrsteensen jrsteensen merged commit 70f1e94 into jrsteensen:master Nov 2, 2020
@jrsteensen jrsteensen added Category: ECAD Electrical CAD/PCB HW Design Priority: Normal Type: Bug/Obsolesce Something isn't working/Part no longer available for sale labels Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: ECAD Electrical CAD/PCB HW Design Priority: Normal Type: Bug/Obsolesce Something isn't working/Part no longer available for sale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants