Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DDI and AMPCD boards #55

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Fixed DDI and AMPCD boards #55

merged 1 commit into from
Oct 24, 2019

Conversation

amanuense
Copy link
Collaborator

added bypass capacitors
added pullup for IRQ line

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Addresses #52

Type of change

Please delete options that are not relevant.

  • New MCAD (new Mechanical Model)
  • Change MCAD (fixed issue with existing MCAD model)
  • New ECAD (new PCB)
  • Change ECAD (fixed issue with existing PCB)
  • New software module (new software module for slave)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: (Delete non-relevant sections)

PCB/ECAD:

  • Requirements definition
  • Schematic completed
  • PCB routed
  • PCB constrained by physical footprint limitations
  • PCB critical component location requirements met
  • PCB and schematic pass DRC check
  • PCB does not have unconnected pads
  • Schematic/PCB reviewed
  • BOM generated
  • Gerbers generated
  • MCAD generated

added bypass capacitors
added pullup for IRQ line
@amanuense amanuense self-assigned this Oct 24, 2019
Copy link
Owner

@jrsteensen jrsteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as is. All action items complete. Ready for dedicated PCB review.

@jrsteensen jrsteensen merged commit b880370 into master Oct 24, 2019
This was referenced Oct 24, 2019
@jrsteensen jrsteensen deleted the ddi_bezel_fix branch October 28, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants