Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate MFG Files: OH2A1A1-1 - ASSY, LOWER INSTRUMENT PANEL STRUCTURE #842

Merged
merged 15 commits into from
May 22, 2023

Conversation

eHanseJoerg
Copy link
Contributor

@eHanseJoerg eHanseJoerg commented May 22, 2023

Description

Initial commit for the Lower Isntrument Panel Structure (LIP), issue #747 . Generated one SVG file for the mount of the UIP on the LIP.

Addresses

Close #747

File generation

OH Wiki HOWTO Link

  • Generate SVG files (if required.)
  • Generate 3MF files (if required.)
  • [-] Generate STEP files (if required.)
  • [-] Copy the relevant decal PDFs from the art folder to the relevant manufacturing folder (if required.)

Review your files

  • Verify against drawing parts list that all the relevant manufacturing files have been created.
  • Open each SVG in your browser and compare against part to ensure it appears the same and its filename is correct.
  • Open each 3MF in a slicer of your choice and verify geometry matches F360 model and its filename is correct.
  • [-] Open each STEP in a STEP file viewer of your choice and verify geometry matches F360 model and its filename is correct.

Submit your files

  • Create a github PR against the beta 1 branch with the manufacturing files located in correct location of the release folder.
  • Request a review of the PR.

@eHanseJoerg
Copy link
Contributor Author

Also kindly check if file name convention is met.

@jrsteensen jrsteensen self-requested a review May 22, 2023 14:39
@jrsteensen jrsteensen assigned jrsteensen and unassigned jrsteensen May 22, 2023
@jrsteensen jrsteensen added Type: Documentation Improvements or additions to documentation Category: MCAD Mechanical CAD labels May 22, 2023
@jrsteensen jrsteensen added this to the v1.0.0-beta1 (Beta 1) milestone May 22, 2023
Copy link
Owner

@jrsteensen jrsteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geometry and file name looks great! Consider using the issue checklist in the PR like @Arribe has in his PRs for the description. The checklist is important so we know everything has been looked at: #841

PR will not be merged until complete - please continue committing files to this PR for the rest of the LIP structure.

@eHanseJoerg
Copy link
Contributor Author

Will do!

@jrsteensen jrsteensen changed the title Initial commit for LIP structure. CSK holes treated. Generate MFG Files: OH2A1A1-1 - ASSY, LOWER INSTRUMENT PANEL STRUCTURE May 22, 2023
@eHanseJoerg
Copy link
Contributor Author

All SVG and 3MF files generated. Kindly check @jrsteensen

Copy link
Owner

@jrsteensen jrsteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Move all manufacturing files into a folder called "Manufacturing" in the LIP Structure assembly.

@eHanseJoerg
Copy link
Contributor Author

Moved to Manuf folder.

@jrsteensen jrsteensen merged commit 5cfdb9c into jrsteensen:v1.0.0-beta1 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: MCAD Mechanical CAD Type: Documentation Improvements or additions to documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants