Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remodel JRubyPluginExtension to allow it to be used as a task extension #366

Closed
ysb33r opened this issue Jun 1, 2019 · 0 comments
Closed

Remodel JRubyPluginExtension to allow it to be used as a task extension #366

ysb33r opened this issue Jun 1, 2019 · 0 comments
Assignees
@ysb33r
Labels
base
Milestone
2.0.0 - Stuttgart

Comments

@ysb33r
Copy link
Contributor

ysb33r commented Jun 1, 2019

This follows a pattern from a number of other plugins whereby a specific task can override settings from the global extension if required.
@ysb33r ysb33r added this to the 2.0.0 - Stuttgart milestone Jun 1, 2019
@ysb33r ysb33r self-assigned this Jun 1, 2019
@ysb33r ysb33r changed the title Remodel JRubyPLuginExtension to allow it to be used as a task extension Remodel JRubyPluginExtension to allow it to be used as a task extension Jun 3, 2019
ysb33r added a commit to ysb33r/jruby-gradle-plugin that referenced this issue Jun 4, 2019
@ysb33r
WIP: (jruby-gradle#366)
780d0f9 
Cleaned up and restructured base-plugin.

- `JRubyPluginExtension`
- `JRubyExec`
- Split out `GemUtils.OverwriteAction` into its own class `GemOverwriteAction`.
- Moved `GemUtils` to `core-plugin`.
- In `JRubyPlugin`, registers tasks instead of creating them if Gradle supports lazy-creation.
- Removed `RubygemsServlet`.
ysb33r added a commit to ysb33r/jruby-gradle-plugin that referenced this issue Jun 4, 2019
@ysb33r
WIP: Reworked GemVersion to be more Ivy-like rather than Maven-like (j…
9cafdd3 
…ruby-gradle#366)
ysb33r added a commit to ysb33r/jruby-gradle-plugin that referenced this issue Jun 5, 2019
@ysb33r
WIP: Reworked JRubyPrepare & JRubyExec (jruby-gradle#366)
f4da9ef
ysb33r added a commit to ysb33r/jruby-gradle-plugin that referenced this issue Jun 5, 2019
@ysb33r
WIP: Extract common JRubyPrepare code to AbstractJRubyPrepare (jruby-…
232de1e 
…gradle#366)
ysb33r added a commit to ysb33r/jruby-gradle-plugin that referenced this issue Jun 5, 2019
@ysb33r
Cleaned up JRubyExec to no longer depend on JRubyExecTraits (jruby-gr…
9cd2963 
…adle#366)

- Removed last usages of jar-dependencies.
ysb33r added a commit to ysb33r/jruby-gradle-plugin that referenced this issue Jun 5, 2019
@ysb33r
Cleaned up JRubyExecDelegate to no longer depend on JRubyExecTraits (j…
a81031e 
…ruby-gradle#366)
ysb33r added a commit to ysb33r/jruby-gradle-plugin that referenced this issue Jun 5, 2019
@ysb33r
WIP: Cleaned up integration tests and unit tests (jruby-gradle#366)
2e93482
ysb33r added a commit to ysb33r/jruby-gradle-plugin that referenced this issue Jun 5, 2019
@ysb33r
Cleaned up and restructured base-plugin (jruby-gradle#366).
ce44d67 
- `JRubyPluginExtension`
- `JRubyExec`
- Split out `GemUtils.OverwriteAction` into its own class `GemOverwriteAction`.
- Moved `GemUtils` to `core-plugin`.
- Removed `RubygemsServlet`.
- Reworked `GemVersion` to be more Ivy-like rather than Maven-like.
- Reworked `JRubyPrepare` & `JRubyExec`.
- Extract common `JRubyPrepare` code to `AbstractJRubyPrepare`.
- Cleaned up `JRubyExec` to no longer depend on `JRubyExecTraits`.
- Cleaned up `JRubyExecDelegate` to no longer depend on `JRubyExecTraits`.
- In `JRubyPlugin`, register tasks instead of creating them if Gradle supports lazy-creation.
- Removed last usages of `jar-dependencies`.
- Cleaned up integration tests and unit tests
ysb33r added a commit to ysb33r/jruby-gradle-plugin that referenced this issue Jun 5, 2019
@ysb33r
Make JRubyExec compatible with Gradle 4.2 - 4.9 (jruby-gradle#366)
fd11f4f
ysb33r added a commit to ysb33r/jruby-gradle-plugin that referenced this issue Jun 5, 2019
@ysb33r
Make JRubyExec compatible with Gradle 4.2 - 4.9 (jruby-gradle#366)
9387364
ysb33r added a commit to ysb33r/jruby-gradle-plugin that referenced this issue Jun 5, 2019
@ysb33r
Update documentation for new features (jruby-gradle#364,jruby-gradle#366
98d86b3 
)
ysb33r added a commit to ysb33r/jruby-gradle-plugin that referenced this issue Jun 5, 2019
@ysb33r
Cleanup Javadoc (jruby-gradle#364,jruby-gradle#366)
e6a8255
@ysb33r ysb33r added the base label Jun 9, 2019
ysb33r added a commit to ysb33r/jruby-gradle-plugin that referenced this issue Jun 10, 2019
@ysb33r
Deprecation message should use log.warn (jruby-gradle#366)
6bab580
ysb33r added a commit that referenced this issue Jun 15, 2019
@ysb33r
Merge pull request #365 from ysb33r/rubygem-api
6fea898 
Improve GEM handling and resolving (#364, #366, #370)
@ysb33r ysb33r closed this as completed Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ysb33r ysb33r

Labels
base
Milestone
2.0.0 - Stuttgart
Development

No branches or pull requests
1 participant
@ysb33r