Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update parameters in Job functions #153

Merged
merged 5 commits into from
Jun 2, 2023
Merged

update parameters in Job functions #153

merged 5 commits into from
Jun 2, 2023

Conversation

IgnacioHeredia
Copy link
Contributor

Just a little update on the parameters in deregister_job(). Tested it.

I choose Union instead of Optional for parameters in line with this.

@IgnacioHeredia IgnacioHeredia changed the title update parameters in deregister_job() update parameters in Job functions May 25, 2023
@nikita-b nikita-b self-requested a review May 26, 2023 14:24
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #153 (2c8e250) into master (364f063) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   90.63%   90.71%   +0.08%     
==========================================
  Files          31       31              
  Lines        1292     1293       +1     
==========================================
+ Hits         1171     1173       +2     
+ Misses        121      120       -1     
Impacted Files Coverage Δ
nomad/api/job.py 94.52% <100.00%> (-0.08%) ⬇️

... and 4 files with indirect coverage changes

@nikita-b
Copy link
Collaborator

@IgnacioHeredia Could you, please, fix the linters?

@IgnacioHeredia
Copy link
Contributor Author

@nikita-b done!

@nikita-b
Copy link
Collaborator

nikita-b commented Jun 1, 2023

LGTM, @IgnacioHeredia thanks for your contribution!

@nikita-b
Copy link
Collaborator

nikita-b commented Jun 1, 2023

@IgnacioHeredia Oh, it seems we still have an issue with black formatter.

@IgnacioHeredia
Copy link
Contributor Author

@nikita-b done!

@nikita-b nikita-b merged commit 41df869 into jrxFive:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants