Only read env variables on __init__ #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-b
approved these changes
Sep 28, 2023
|
Something happened to CI...I'll check on weekends. @atwam Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default values for arguments to
Nomad.__init__are read when the class is initialized (so when python reads__init__.py.If one later want to change the values of the
NOMAD_*env variables, these new values will get ignored because by then the defaults for arguments are already set.This changes the commit to have a proper
Nonedefault, and only read the current values of env variables when__init__()is called.See https://medium.com/@nebiyuelias1/be-careful-when-using-default-arguments-in-python-fd92df94efee for why defining the default with a function call is prone to error.