Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS.hasChanges() reports changes after loading relations #165

Closed
TimothyKrell opened this issue Sep 12, 2014 · 1 comment
Closed

DS.hasChanges() reports changes after loading relations #165

TimothyKrell opened this issue Sep 12, 2014 · 1 comment
Assignees
@jmdobry
Labels
bug done
Milestone
1.0.0-rc.2

Comments

@TimothyKrell
Copy link
Contributor

I made pull request #164 with a failing test to show what I'm talking about.

I'm not sure how you want to fix this (or if I'm missing something about how this should work). Also, I'm getting changes reported for injecting a resource with methods defined, but I haven't been able to get the test to fail for that, oddly.
@jmdobry
Copy link
Member

jmdobry commented Sep 12, 2014

The fix is to have changes and hasChanges ignore the relations fields.

@jmdobry jmdobry self-assigned this Sep 12, 2014
@jmdobry jmdobry added this to the 1.0.0-rc.2 milestone Sep 12, 2014
@jmdobry jmdobry added done and removed ready labels Sep 15, 2014
jmdobry added a commit to js-data/js-data that referenced this issue Sep 15, 2014
@jmdobry
Backport js-data/js-data-angular#165.
5c4f489
@jmdobry jmdobry mentioned this issue Sep 15, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmdobry jmdobry

Labels
bug done
Projects
None yet
Milestone
1.0.0-rc.2
Development

No branches or pull requests
2 participants
@jmdobry @TimothyKrell