Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ng-repeat $$hashKey affecting hasChanges #208

Closed
statianzo opened this issue Oct 14, 2014 · 1 comment
Closed

ng-repeat $$hashKey affecting hasChanges #208

statianzo opened this issue Oct 14, 2014 · 1 comment
Assignees
@jmdobry
Labels
1.0 2.0 done feature
Milestone
2.0.0

Comments

@statianzo
Copy link

After putting a list of models through an ng-repeat, the $$hashKey property gets added and calling DS.hasChanges will report true. What are your thoughts on adding a special case for this key like angular.copy does?
@jmdobry
Copy link
Member

jmdobry commented Oct 14, 2014

Good catch, I will add it, but I will allow configuration of blacklisted fields names that will be ignored by the dirty-checker.

@jmdobry jmdobry self-assigned this Oct 14, 2014
@jmdobry jmdobry closed this as completed in 6c2fce6 Nov 2, 2014
jmdobry added a commit that referenced this issue Nov 2, 2014
@jmdobry
Merge pull request #224 from Medycation/master
5609dcb 
Fixes #208.
@jmdobry jmdobry added done and removed backlog labels Nov 4, 2014
jmdobry added a commit to js-data/js-data that referenced this issue Nov 4, 2014
@jmdobry
Port js-data/js-data-angular#208 and js-data/js-data-angular#225.
367929c 
Stable Version 1.0.0-alpha.4-0.
@jmdobry jmdobry added this to the 2.0.0 milestone Nov 8, 2014
@rgant rgant mentioned this issue Jul 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmdobry jmdobry

Labels
1.0 2.0 done feature
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@statianzo @jmdobry