Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 support #235

Closed
sergproua opened this issue Nov 9, 2014 · 0 comments
Closed

IE8 support #235

sergproua opened this issue Nov 9, 2014 · 0 comments
Assignees

Comments

@sergproua
Copy link

Would be nice to have IE8 support while AngularJS 1.X is supported. I was able to get it to work on IE8 with AngulaJS 1.x by replacing the following, please advise if I should submit a pull request

  1. delete - reserved word

    var expectedRecordTypes = {
    add: true,
    update: true,
    'delete': true // wrapped
    };

  2. catch - reserved word

.catch(...) in promise calls should be replaced with 'catch'

  1. class - reserved word

.class should be replaced with ['class']

  1. Object.create() does not exist but seems to work with https://github.com/es-shims/es5-shim. As an example of possible replacement
    IllegalArgumentError.prototype = Object.create(Error.prototype);
    Can be replaced with:
    IllegalArgumentError.prototype = new Error();
jmdobry added a commit that referenced this issue Nov 9, 2014
Stable Version 1.4.0.
@jmdobry jmdobry closed this as completed Nov 9, 2014
@jmdobry jmdobry self-assigned this Nov 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants