-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed requests should throw an error, not just return it #69
Comments
For more info, checkout propagation from the q library. |
I found where Angular's Their example uses |
Since 1.0.2 |
There are a five or six places that need to be changed from |
So, why can't we just rethrow the error? |
I imagine |
Ok, cool |
On this line in
findAll
, when the request fails (404 for example) angular-data is returning the error. This causes a resolve in a route to resolve to the error. Because of this when I do this, my injected users is the err object that angular-data is returning (not great...)Let me know if I need to be more clear on what is actually happening. But I'm pretty sure all that needs to happen is on that line we need to change the "return" to "throw"
The text was updated successfully, but these errors were encountered: