Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS.create isn't added to completedQueries #90

Closed
chieffancypants opened this issue Jul 11, 2014 · 2 comments
Closed

DS.create isn't added to completedQueries #90

chieffancypants opened this issue Jul 11, 2014 · 2 comments
Assignees
Milestone

Comments

@chieffancypants
Copy link
Contributor

Not sure if the response to DS.create belongs in completedQueries or not, but would be useful if it was as it would avoid an unnecessary XHR:

DS.create('document', { author: 'John Anderson' })
  .then(function (document) {
    DS.get('document', document.id)  // pulls from cache properly
    DS.find('document', document.id) // triggers another XHR for the same document already in the cache
  });

Thanks for all the great work on this library!

@jmdobry jmdobry self-assigned this Jul 11, 2014
@jmdobry
Copy link
Member

jmdobry commented Jul 11, 2014

@chieffancypants That's a good catch! I'll add it.

@jmdobry jmdobry added this to the 0.10.1 milestone Jul 18, 2014
@jmdobry
Copy link
Member

jmdobry commented Jul 20, 2014

Fixed as of 0.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants