Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS.findAll wasn't added to completedQueries #101

Merged
merged 1 commit into from
Jul 22, 2014

Conversation

chieffancypants
Copy link
Contributor

Hi there, back again with a similar issue to #90. There may be more of these, but just opening tickets as I encounter them. Figured this time I'd help resolve it

DS.findAll caches all objects properly, but DS.find() doesn't pull from the cache and instead triggers a new XHR:

DS.findAll('document').then(function (documents) {
    DS.get('document', documents[0].id)  // pulls from cache properly
    DS.find('document', documents[0].id) // triggers another XHR for the same document already in the cache
  });

jmdobry added a commit that referenced this pull request Jul 22, 2014
DS.findAll wasn't added to completedQueries
@jmdobry jmdobry merged commit 87b167a into js-data:master Jul 22, 2014
jmdobry added a commit that referenced this pull request Jul 24, 2014
Stable Version 0.10.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants