Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower: update bower.json acc to the spec #263

Merged
merged 1 commit into from
Dec 3, 2014
Merged

bower: update bower.json acc to the spec #263

merged 1 commit into from
Dec 3, 2014

Conversation

thorn0
Copy link
Contributor

@thorn0 thorn0 commented Dec 3, 2014

Bower uses git tags and ignores the version field.
See https://github.com/bower/bower.json-spec#version
Also according to the same spec, minified files shouldn't be included to main.

Bower uses git tags and ignores the `version` field.
See https://github.com/bower/bower.json-spec#version
Also according to the same spec, minified files shouldn't be included to `main`.
@jmdobry
Copy link
Member

jmdobry commented Dec 3, 2014

Do all versions of Bower ignore the version field? If not, then we should leave it there, so as to not break anything for anybody using an older version of bower. And since it's intended to be used in the future, why not leave it there?

@thorn0
Copy link
Contributor Author

thorn0 commented Dec 3, 2014

AFAIK it was never used. See bower/bower#1303

As for the future, the spec says about a use case when packages are published in Bower's own registry, just like npm works. But this registry so far doesn't exist. When/if they implement it, and you decide to publish the package there, this field might get needed. But other changes to the release process would be needed as well, at least you'd have to run a command to publish the package.

And now it's just one thing less to worry about while rolling out a release.

jmdobry added a commit that referenced this pull request Dec 3, 2014
bower: update bower.json acc to the spec
@jmdobry jmdobry merged commit 9a9c976 into js-data:master Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants