react-redux.js.org #2391
Merged
react-redux.js.org #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently working on setting up docs publishing for React-Redux, per reduxjs/react-redux#1031 . Site is hosted at https://react-redux-docs.netlify.com/ . Semi-placeholder content for now (just the one page). We'll start publishing things for real as soon as we can figure out which site gen tool we're using. CNAME has been added at https://github.com/reduxjs/react-redux/blob/master/CNAME , and we're good with the terms and conditions.
MattIPv4
approved these changes
Oct 6, 2018
indus
added
invalid
add
|
@markerikson The CNAME in the repo is only needed for GH pages. When you use netlify (or any other host that supports CNAME based redirects) you usually have to configure the "custom domain" in the settings of your hosting. In your case this should help: https://www.netlify.com/docs/custom-domains/ |
|
Thanks for the info. I just set my Netlify site to point to |
|
LGTM Welcome https://react-redux.js.org |
|
Sweet, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently working on setting up docs publishing for React-Redux, per reduxjs/react-redux#1031 .
Site is hosted at https://react-redux-docs.netlify.com/ . Semi-placeholder content for now (just the one page). We'll start publishing things for real as soon as we can figure out which site gen tool we're using.
CNAME has been added at https://github.com/reduxjs/react-redux/blob/master/CNAME , and we're good with the terms and conditions.