Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-chartjs-2.js.org #9470

Merged
merged 1 commit into from
Dec 30, 2024
Merged

react-chartjs-2.js.org #9470

merged 1 commit into from
Dec 30, 2024

Conversation

dangreen
Copy link
Contributor

The site content is react-chartjs-2 library documentation

@indus indus changed the title update react-chartjs-2 update react-chartjs-2.js.org Dec 30, 2024
@indus indus changed the title update react-chartjs-2.js.org react-chartjs-2.js.org Dec 30, 2024
@indus indus added organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages labels Dec 30, 2024
@indus
Copy link
Member

indus commented Dec 30, 2024

I've already added your requested changed the subdomain to in JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@dangreen
Copy link
Contributor Author

@indus just changed domain in pages settings

@indus
Copy link
Member

indus commented Dec 30, 2024

I had a look here and it seems to work.
(only a small issue with the base url in docsaurus)

Welcome back https://react-chartjs-2.js.org/

@indus indus merged commit 8b0002e into js-org:master Dec 30, 2024
1 check passed
@dangreen
Copy link
Contributor Author

@indus Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants