Skip to content

Commit

Permalink
Merge pull request openshift#15906 from pravisankar/fix-stale-comment
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue (batch tested with PRs 15896, 15921, 15909, 15911, 15906)

Update stale comment: We use colon instead of underscore between name…

…space and route name for uniquely identifying the route in the router
  • Loading branch information
openshift-merge-robot authored Aug 24, 2017
2 parents 8221c1a + 76edd6d commit e5b4a1c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/router/template/router.go
Original file line number Diff line number Diff line change
Expand Up @@ -551,10 +551,10 @@ func (r *templateRouter) routeKey(route *routeapi.Route) string {
name := controller.GetSafeRouteName(route.Name)

// Namespace can contain dashes, so ${namespace}-${name} is not
// unique, use an underscore instead - ${namespace}_${name} akin
// unique, use an underscore instead - ${namespace}:${name} akin
// to the way domain keys/service records use it ala
// _$service.$proto.$name.
// Note here that underscore (_) is not a valid DNS character and
// Note here that colon (:) is not a valid DNS character and
// is just used for the key name and not for the record/route name.
// This also helps the use case for the key used as a router config
// file name.
Expand Down

0 comments on commit e5b4a1c

Please sign in to comment.