V2 : fix transforms #521
Merged
V2 : fix transforms #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meters added or corrected documentation
|
@kaosat-dev please review. let me know if anything should be changed. |
|
@kaosat-dev Can this be merged? I reviewed again, and think this is ready. |
|
@z3dev reviewing now, sorry for the delay ! |
kaosat-dev
suggested changes
Mar 9, 2020
There was a problem hiding this comment.
Very nice & clean @z3dev !
Only question/remark/suggestion I have is about allowing to use a single scalar value (a float) that gets converted to array, instead of forcing arrays ?
|
@kaosat-dev please merge. |
|
Time to push on. Thanks, @kaosat-dev for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow various length arrays to be passed to:
NOTE: center() was not changed, as that should be done seperately.
All Submissions: