Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 : Fix Deserializers #527

Merged
merged 4 commits into from
Mar 11, 2020
Merged

V2 : Fix Deserializers #527

merged 4 commits into from
Mar 11, 2020

Conversation

z3dev
Copy link
Member

@z3dev z3dev commented Mar 3, 2020 •
edited
Loading

These changes update the various deserializers to:

  • deserialize(options, source)
  • new options.filename
  • corrected options.output to accept only 'script' or 'geometry'

And of course, updating CLI and CORE code to use these new standards.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

z3dev added 3 commits March 3, 2020 11:37
@z3dev
fix(io) reworked deserializers; deserialize(options, source)
c3daaa2 
standardized use of option.output to 'script' or 'geometry'
added export of extension from each deserializer
updated test suites
@z3dev
fix(core) updated usage of deserialize() functions to match new signi…
da705be 
…ture

updated test suites
@z3dev
fix(cli) updated usage of deserializers to match new function signiture
8353679
@kaosat-dev kaosat-dev mentioned this pull request Mar 3, 2020
Closed
58 tasks
@z3dev z3dev requested a review from kaosat-dev March 9, 2020 10:01
@z3dev
Copy link
Member Author

z3dev commented Mar 9, 2020

@kaosat-dev please review.

kaosat-dev
kaosat-dev approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@kaosat-dev kaosat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pfeww ! that is a lot of good change @z3dev , well done !
I am ok with merging, I just have two questions regarding some minor details (see review), thanks !

packages/cli/src/generateOutputData.js Show resolved Hide resolved
packages/cli/src/generateOutputData.js Show resolved Hide resolved
packages/io/amf-deserializer/deserialize.js Outdated Show resolved Hide resolved
packages/io/stl-deserializer/tests/translate.test.js Show resolved Hide resolved
@z3dev
Copy link
Member Author

z3dev commented Mar 10, 2020

@kaosat-dev please merge

@kaosat-dev kaosat-dev merged commit e64677f into V2 Mar 11, 2020
@z3dev z3dev deleted the fix-deserializers branch March 28, 2020 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaosat-dev kaosat-dev kaosat-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@z3dev @kaosat-dev