V2 : primitives revisted

[z3dev]

These changes improve the checking of parameters (options) in the primitives.

NOTE: There are also changes to the tests suites to comply with coding standards.

Fixes #633
Fixes #626

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Does your submission pass tests?

[z3dev]

There's a lot of redundant code in the primitives, especially the redundant error messages/strings. I can see two ways to address this.

1. create a set of common functions to perform common checks, e.g. checkCenter()
2. keep the unique checks in the code, and create a set of common functions to throw common errors

Perferences anyone? Suggestions?

[SimonClark]

There's a lot of redundant code in the primitives, especially the redundant error messages/strings. I can see two ways to address this.

1. create a set of common functions to perform common checks, e.g. checkCenter()
2. keep the unique checks in the code, and create a set of common functions to throw common errors

Perferences anyone? Suggestions?

I think I'd prefer to see a set of options validator functions. Make for more readable code imo

[z3dev]

@SimonClark thanks.

I implemented some common checks (actually more complete), and reworked the code for the primitives. Looks better, more readable, but I still don't like the redundant comments.