Issue #982 A UX improvement on skipping rotation while pinching on mobile devices

[samuelwang48]

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Does your submission pass tests?

Note: please do NOT include build files (those generate by the build-xxx commands) with your PR,

Thank you for your help in advance, much appreciated !

[samuelwang48]

My apologies if I missed this in the contribution guide. Could you please let me know if it was on purpose all the semicolons are omitted? Is it documented somewhere?

[hrgdavor]

there is standardx tool that you need to run after changing files. it is almost the same as https://standardjs.com/ but allows few customizations. The tool will let you know if file is not formated to that style and also has --fix option to fix automatically those that can be fixed reliably

[samuelwang48]

Thanks very much. I will rework this commit and get back.

On Wed, Jan 26, 2022 at 02:34 Davor Hrg ***@***.***> wrote: there is standardx tool that you need to run after changing files. it is almost the same as https://standardjs.com/ but allows few customizations. The tool will let you know if file is not formated to that style and also has --fix option to fix automatically those that can be fixed reliably — Reply to this email directly, view it on GitHub <#983 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFVCX7QE72PSOUPSAXY7Z3TUX6PXLANCNFSM5M2HUBJA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Thanks Sam

[hrgdavor]

Also if you use discord feel free to join the jscad channel https://discord.com/channels/412182089279209474/758341118177050634/935275349586116648

[samuelwang48]

Also if you use discord feel free to join the jscad channel https://discord.com/channels/412182089279209474/758341118177050634/935275349586116648

Looks like the channel is not accessible to me. Will check it later.

[samuelwang48]

Thanks to @hrgdavor 's tips on formatting the code.
I had ran the below commands to fix the format. Amended the commit and now ready for review.
standard --fix %filenames%

[hrgdavor]

Code looks good to me, but I do not have any ios device to test. Maybe @z3dev has something to test and approve this PR.

[z3dev]

@samuelwang48 Thanks for the changes. The changes look fine but must work across all browsers, both PC and mobile browsers.

I’ll do some testing this weekend across browsers.

What browsers did you test with?

[samuelwang48]

Hi Z3, I did my manual tests on: - M1 Mac - chrome, safari - iPhone iOS 14, 15 - chrome, safari - iPad iOS 15 - chrome, safari - iOS SDK - WKWebView Thanks for your help.

On Mon, Jan 31, 2022 at 07:35 Z3 Development ***@***.***> wrote: @samuelwang48 <https://github.com/samuelwang48> Thanks for the changes. These look fine but must work across all browsers, both PC and mobile browsers. I’ll do some testing this weekend across browsers. What browsers did you test with? — Reply to this email directly, view it on GitHub <#983 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFVCX7WWNNNV2V6Q3WKVNY3UYZ6YDANCNFSM5M2HUBJA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Thanks Sam

[z3dev]

I tested on MacOS (Firefox, Safari, and Chrome) with track pad, and wheel mouse.

I also tested with iPad with Firefox, Safari, Edge, and Chrome.

Everything worked just fine, @samuelwang48

Thanks for these changes!

[z3dev]

Looks good!

[hrgdavor]

@samuelwang48 nice to see new committers, hope to see even more PRs in the future :)

if u are chatty like I am, you can also join jscad channel on CadHub discord server https://discord.gg/AaqGskur93

[samuelwang48]

@z3dev Hi thanks for taking time to test it.
@hrgdavor Thanks for the info. I've joined.
Really glad to be here. Filed a few new issues while scanning through all the documentation. Will be looking into it.