Fix FTP multiple nested paths (#886)

Co-authored-by: Josh Schneier <josh.schneier@gmail.com>
jschneier · May 31, 2020 · 993833b · 993833b
1 parent b116e3a
commit 993833b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/storages/backends/ftp.py b/storages/backends/ftp.py
@@ -111,7 +111,7 @@ def disconnect(self):
 
     def _mkremdirs(self, path):
         pwd = self._connection.pwd()
-        path_splitted = os.path.split(path)
+        path_splitted = path.split(os.path.sep)
         for path_part in path_splitted:
             try:
                 self._connection.cwd(path_part)

diff --git a/tests/test_ftp.py b/tests/test_ftp.py
@@ -103,6 +103,11 @@ def test_mkremdirs(self, mock_ftp):
         self.storage._start_connection()
         self.storage._mkremdirs('foo/bar')
 
+    @patch('ftplib.FTP', **{'return_value.pwd.return_value': 'foo'})
+    def test_mkremdirs_n_subdirectories(self, mock_ftp):
+        self.storage._start_connection()
+        self.storage._mkremdirs('foo/bar/null')
+
     @patch('ftplib.FTP', **{
         'return_value.pwd.return_value': 'foo',
         'return_value.storbinary.return_value': None