-
-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Cloud Storage: Cache Control #411
Comments
Hello, actually this is very important to use google cloud as storage backend. Because google-cdn requires cache-control headers to cache google-cloud-storage files. |
In case anybody else ends up here, to solve this issue I made a custom storage backend with updated _save method like this:
@ezarowny, thanks for sharing api for this. |
Thanks for sharing, @gfhuseyinyilmaz wouldn't it be nice to have it as a setting? The same way it is for S3? |
Hi, I've opened a PR for this #459 |
@zamai It would be nice to have it as a setting, but most of the time you want different headers for different type of files, this would be a really nice feature imho. |
Is this project still active? This setting seems like a necessity as not everyone wants |
@nbau21 not as much as it deserves. There is a fair amount of duplicity and technical debt from when I forked it combined with me shifting to freelance has sort of crushed a lot of my time & will. Ideally people who added large backends would be happy to maintain them but I don't think they owe anything to anyone. Obviously just added in this fix to master. Thanks for the ping. |
Thanks for the response. It's the beauty of open source, anyone can chime in, fork, etc. Also thanks for merging this to master. I didn't mean to sound entitled in my previous post- I guess I was a bit frustrated at the lack of support for Google Cloud Storage in Django, compared to AWS. |
It'd be nice to be able set the cache control header at the time of object upload. The docs for this can be found here: https://googlecloudplatform.github.io/google-cloud-python/latest/storage/blobs.html#google.cloud.storage.blob.Blob.cache_control
The text was updated successfully, but these errors were encountered: