Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion between AWS_S3_SECURE_URLS, AWS_S3_USE_SSL, AWS_S3_URL_PROTOCOL #472

Closed
siyu6974 opened this issue Mar 15, 2018 · 2 comments
Closed

Comments

@siyu6974
Copy link

I found it very confusing and not very well documented for these 3 settings.

AWS_S3_SECURE_URLS
AWS_S3_USE_SSL
AWS_S3_URL_PROTOCOL
@jschneier
Copy link
Owner

Yeah that is fair. AWS_USE_SSL is about the connection to S3 (like your server to S3). It was introduced here 6071ac3 and was in the codebase before the fork. I'm not really sure if it should be around anymore.

The other two are about constructing urls. In the legacy backend you could specify for boto to give you an http link but the api changed between boto and boto3 so right now it (AWS_S3_SECURE_URLS) doesn't do too much in boto3 although for backwards-compat and safety reasons it sets url_protocol to https: when it is True (the default). AWS_S3_URL_PROTOCOL is for setting the protocol if you are using a custom domain (Cloudfront or similar) and want to force http.

The settings need to be cleaned up and the documentation updated. Removing the boto backend will really help.

jschneier added a commit that referenced this issue Aug 5, 2022
Remove AWS_S3_SECURE_URLS setting
Update AWS_S3_URL_PROTOCOL setting to default to https:
Document AWS_S3_URL_PROTOCOL

Resolves #1126, #1150, #472
@jschneier
Copy link
Owner

Resolved by #1164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants