Fix S3Boto3Storage to avoid race conditions in a multi-threaded WSGI environment #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…environment Use a different boto3 session for each instance of the S3 connection.
Current coverage is 59.27% (diff: 33.33%)@@ master #238 diff @@
==========================================
Files 17 17
Lines 1692 1692
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 1004 1003 -1
- Misses 688 689 +1
Partials 0 0
|
|
Unfortunate about upstream. Thanks for the fix. |
jschneier
added a commit
that referenced
this pull request
Jan 12, 2017
This was referenced Jan 13, 2017
This was referenced Jan 16, 2017
This was referenced Jun 21, 2017
This was referenced Jul 27, 2017
This was referenced Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a different boto3 session for each instance of the S3 connection.
Resurrecting from PR #200 as upstream does not appear to be moving on a change. This fixes the race as far as django-storages is concerned.