Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#257: S3Boto3Storage bucket_params #258

Merged
merged 2 commits into from
Feb 28, 2017
Merged

#257: S3Boto3Storage bucket_params #258

merged 2 commits into from
Feb 28, 2017

Conversation

mattayes
Copy link
Contributor

@mattayes mattayes commented Jan 27, 2017

Hey folks, the only change this makes is to use bucket_params when calling bucket.create().

I'm not sure the best way to test this and would love some advice. Thanks!

Resolves #257.

@codecov-io
Copy link

codecov-io commented Jan 27, 2017

Current coverage is 59.32% (diff: 0.00%)

Merging #258 into master will not change coverage

@@             master       #258   diff @@
==========================================
  Files            17         17          
  Lines          1694       1694          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1005       1005          
  Misses          689        689          
  Partials          0          0          

Powered by Codecov. Last update 7d99131...4f643ed

@jschneier jschneier merged commit 7bb7e2b into jschneier:master Feb 28, 2017
This was referenced Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants