SpooledTemporaryFile.write() is meant to be called with small chunks,… #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not once with a large payload
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
- Coverage 76.1% 76.05% -0.06%
==========================================
Files 11 11
Lines 1578 1566 -12
==========================================
- Hits 1201 1191 -10
+ Misses 377 375 -2
Continue to review full report at Codecov.
|
|
This fix was merged in ea0986d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… not once with a large payload
This fixes #383.
It was sending the entire contents of the S3 file to SpooledTemporaryFile.write() in a single call which defeats the purpose of using SpooledTemporaryFile as it only checks if it needs to switch to disk after each write.