Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dropbox storage #76

Merged
merged 2 commits into from
Sep 18, 2015
Merged

Added dropbox storage #76

merged 2 commits into from
Sep 18, 2015

Conversation

ZuluPro
Copy link
Contributor

@ZuluPro ZuluPro commented Aug 24, 2015

  • Supports Dropbox oAuth API
  • Added with unittests
  • Maybe you want some doc in this pull request ?

Further:

  • Support auth with API key and secret
  • Ensure locations are great

@ZuluPro ZuluPro force-pushed the dropbox branch 2 times, most recently from a3390b7 to 2deb3f3 Compare August 26, 2015 12:16
@ZuluPro
Copy link
Contributor Author

ZuluPro commented Aug 26, 2015

I had some troubles with dropbox library and Python 3.
The library installed from SDK doesn't seem to be up to date and doesn't work with Py3.

I instead use their official repo: https://github.com/dropbox/dropbox-sdk-python
with pip install https://github.com/dropbox/dropbox-sdk-python/archive/master.zip

@ZuluPro ZuluPro mentioned this pull request Aug 27, 2015
Closed
@ZuluPro
Copy link
Contributor Author

ZuluPro commented Sep 2, 2015

Any news ?

@jschneier
Copy link
Owner

The code looks great.

jschneier
jschneier reviewed Sep 8, 2015
View reviewed changes
storages/backends/dropbox.py
@@ -0,0 +1,98 @@
# FTP storage class for Django pluggable storage system.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove the FTP stuff :)

@ZuluPro ZuluPro force-pushed the dropbox branch 2 times, most recently from 3714231 to 7f1c48b Compare September 8, 2015 17:30
@ZuluPro
Copy link
Contributor Author

ZuluPro commented Sep 8, 2015

All is done!

@ZuluPro ZuluPro force-pushed the dropbox branch 2 times, most recently from ee169a4 to 0f6bb2a Compare September 8, 2015 21:34
@ZuluPro
Copy link
Contributor Author

ZuluPro commented Sep 8, 2015

I don't know why Travis don't launch test for my pull request, but it successes here: https://travis-ci.org/ZuluPro/django-storages/builds/79368054

@ZuluPro
Copy link
Contributor Author

ZuluPro commented Sep 12, 2015

@jschneier Any news ?

jschneier added a commit that referenced this pull request Sep 18, 2015
@jschneier
Merge pull request #76 from ZuluPro/dropbox
f2880b1 
Added dropbox storage
@jschneier jschneier merged commit f2880b1 into jschneier:master Sep 18, 2015
@ZuluPro ZuluPro mentioned this pull request Feb 1, 2016
Closed
This was referenced Jul 27, 2016
Merged
Closed
Merged
@pyup-bot pyup-bot mentioned this pull request Jan 25, 2017
Closed
@pyup-bot pyup-bot mentioned this pull request Mar 27, 2017
Open
@pyup-bot pyup-bot mentioned this pull request Aug 12, 2017
Closed
@pyup-bot pyup-bot mentioned this pull request Nov 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZuluPro @jschneier