Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add default implementation of get_default_settings to BaseStorage #864

Merged
merged 1 commit into from
Apr 15, 2020
Merged

add default implementation of get_default_settings to BaseStorage #864

merged 1 commit into from
Apr 15, 2020

Conversation

terencehonles
Copy link
Contributor

@terencehonles terencehonles commented Mar 18, 2020 •
edited
Loading

Based on my comment #524 (comment)

I'm not sure an empty {} is warranted because it's likely that a storage is providing some options, and it should use the get_default_settings for that? Or do you suspect people would create a new storage based off the BaseStorage that would have no settings? I guess for maybe a private source/single use storage that might be the case.

@jdufresne not sure if you had seen my subsequent comment (linked), but figured I could create a PR to discuss.

jdufresne
jdufresne approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@jdufresne jdufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way works for me. Thanks.

@jschneier jschneier merged commit 2712b01 into jschneier:master Apr 15, 2020
@terencehonles terencehonles deleted the add-default-implementation-of-get_default_settings branch April 16, 2020 22:00
mlazowik pushed a commit to qedsoftware/django-storages that referenced this pull request Mar 9, 2022
@terencehonles @mlazowik
Add default implementation of get_default_settings to BaseStorage (js…
f2615f8 
…chneier#864)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdufresne jdufresne jdufresne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terencehonles @jdufresne @jschneier