Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create harmeet_singh #2029

Merged
merged 6 commits into from
May 23, 2024
Merged

Create harmeet_singh #2029

merged 6 commits into from
May 23, 2024

Conversation

harmeet24
Copy link
Contributor

I would like to register for JS CraftCamp.

  • My pull request contains a JSON file $name_or_nickname.json
  • I read the THE IMPORTANT STUFF at https://jscraftcamp.org/registration, the JSON file follows the template, and contains the mandatory fields like realName, githubAccountName, when, iCanTakeNotesDuringSessions, whatIsMyConnectionToJavascript and whatCanIContribute.
  • If I can NOT attend, I will either send another pull request removing my JSON file or an e-mail with the subject 'UNREGISTER' to team@jscraftcamp.org
  • I agree that the data I enter in the registration can be used for running the event, e.g. make a name tag, count me as participant. I acknowledge that my data are public on GitHub and I agree that I will be listed on the JSCraftCamp website as a participant.
  • I agree that photos and videos might be taken and published (e.g. on social media) during the event.
  • I understand that I might NOT get a T-Shirt, because they might be in production already
  • I asked my company about sponsoring (see open items at: https://github.com/orgs/jscraftcamp/projects/7)

Are you from a sponsoring company?

  • Yes, I am from company ?????

Copy link

netlify bot commented May 22, 2024

Deploy Preview for jscraftcamp ready!

Name Link
🔨 Latest commit 6fa94d5
🔍 Latest deploy log https://app.netlify.com/sites/jscraftcamp/deploys/664e4d0a55bf55000983e1c1
😎 Deploy Preview https://deploy-preview-2029--jscraftcamp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 22, 2024

Deploy Preview for jscraftcamp ready!

Name Link
🔨 Latest commit 6fa94d5
🔍 Latest deploy log https://app.netlify.com/sites/jscraftcamp/deploys/664e4d0a55bf55000983e1c1
😎 Deploy Preview https://deploy-preview-2029--jscraftcamp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 22, 2024

Deploy Preview for jscraftcamp ready!

Name Link
🔨 Latest commit 38f0c6d
🔍 Latest deploy log https://app.netlify.com/sites/jscraftcamp/deploys/664ef26e41c1240008e56e70
😎 Deploy Preview https://deploy-preview-2029--jscraftcamp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 22, 2024

Deploy Preview for jscraftcamp ready!

Name Link
🔨 Latest commit 2c811f2
🔍 Latest deploy log https://app.netlify.com/sites/jscraftcamp/deploys/664e4d48c234c00008d8598f
😎 Deploy Preview https://deploy-preview-2029--jscraftcamp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@meldron meldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @harmeet24, please add the json file extension to your newly added file!

Copy link
Member

@Narigo Narigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harmeet24 sorry, there is another change to be made. Looks like the X value didn't go through - no need for the @ sign there!

participants/harmeet_singh.json Outdated Show resolved Hide resolved
@harmeet24
Copy link
Contributor Author

Hi @harmeet24 sorry, there is another change to be made. Looks like the X value didn't go through - no need for the @ sign there!

I fixed the issue, please have a look :)

@harmeet24 harmeet24 requested a review from meldron May 23, 2024 09:49
@harmeet24
Copy link
Contributor Author

Hey @harmeet24, please add the json file extension to your newly added file!

done

@harmeet24 harmeet24 requested a review from Narigo May 23, 2024 09:50
@meldron meldron merged commit 380c7c8 into jscraftcamp:main May 23, 2024
5 checks passed
@meldron
Copy link
Member

meldron commented May 23, 2024

Thanks a lot for fixing the PR, welcome to JSCC, see you there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants