Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): 🛠 setup continuous deployment #108

Merged
merged 7 commits into from
Oct 25, 2021
Merged

Conversation

yjaaidi
Copy link
Member

@yjaaidi yjaaidi commented Oct 25, 2021

🚀 Let's auto-publish everything!

@yjaaidi yjaaidi marked this pull request as draft October 25, 2021 13:51
@yjaaidi
Copy link
Member Author

yjaaidi commented Oct 25, 2021

@edbzn do you know why we explicitly specify ref & repository?
It's the initial setup so I can't find the reason in the commits history.
I don't think it's necessary, even for external PRs (i.e. from a fork) so let's remove this and see what happens.

    - name: Checkout all commits
      uses: actions/checkout@v2
      with:
        ref: ${{ github.event.pull_request.head.ref }}
        repository: ${{ github.event.pull_request.head.repo.full_name }}
        fetch-depth: 0

Override npm url with auth token only when needed as the command fails if NPM_TOKEN is not set:
Failed to replace env in config: ${NPM_TOKEN}
@yjaaidi yjaaidi marked this pull request as ready for review October 25, 2021 16:47
@yjaaidi yjaaidi requested a review from edbzn October 25, 2021 16:48
@yjaaidi yjaaidi merged commit 22e516d into main Oct 25, 2021
@yjaaidi yjaaidi deleted the continuous-deployment branch December 9, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant