Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semver): resolve boolean arguments correctly #361

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

garethdjohn
Copy link
Contributor

Fixes #353

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #361 (68a02f6) into main (12468de) will increase coverage by 0.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   92.82%   93.58%   +0.76%     
==========================================
  Files          21       21              
  Lines         390      390              
  Branches       65       65              
==========================================
+ Hits          362      365       +3     
+ Misses         14       12       -2     
+ Partials       14       13       -1     
Impacted Files Coverage Δ
...c/executors/version/utils/resolve-interpolation.ts 73.33% <100.00%> (ø)
.../semver/src/executors/version/utils/post-target.ts 88.88% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12468de...68a02f6. Read the comment docs.

@yjaaidi yjaaidi self-assigned this Oct 25, 2021
@yjaaidi yjaaidi self-requested a review October 25, 2021 14:02
@yjaaidi
Copy link
Member

yjaaidi commented Oct 25, 2021

LGTM!
Great job @garethdjohn!

(thank you for removing the fit too 😉)

@yjaaidi yjaaidi merged commit bbd55dd into jscutlery:main Oct 25, 2021
@garethdjohn garethdjohn deleted the fix-issue-353 branch October 25, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postTargets is running build target in watch mode
2 participants