-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rate limits for GET #549
Conversation
8dbc87a
to
0f3db42
Compare
0f3db42
to
2b1dfc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some more thought, I think this limit should always be applied per IP address. The effect will be more or less the same, but there is a good reason we had CORS configured to disallow sending the tokens on GET. Doing so triggers additional preflight requests, which add extra load, and also makes it much harder to add a CDN caching for finished measurements in the future.
c5709a8
to
6e34c3b
Compare
Fixes #526